[ML] Add getpriority/setpriority to Linux system call whitelist #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support elastic#1109. The risk with setpriority is that it can possibly be used on a different process. However, it is extremely unlikely that the user that Elasticsearch is running as in production will have been granted permission to call it. Running as root is banned and it's an extra admin action to grant the privilege to any other user and there is no good reason for it to have been granted to the Elasticsearch user.
|
retest |
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Apr 3, 2020
This is to support elastic#1109. The risk with setpriority is that it can possibly be used on a different process. However, it is extremely unlikely that the user that Elasticsearch is running as in production will have been granted permission to call it. Running as root is banned and it's an extra admin action to grant the privilege to any other user and there is no good reason for it to have been granted to the Elasticsearch user. Backport of elastic#1117
droberts195
added a commit
that referenced
this pull request
Apr 3, 2020
…1124) This is to support #1109. The risk with setpriority is that it can possibly be used on a different process. However, it is extremely unlikely that the user that Elasticsearch is running as in production will have been granted permission to call it. Running as root is banned and it's an extra admin action to grant the privilege to any other user and there is no good reason for it to have been granted to the Elasticsearch user. Backport of #1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support #1109.
The risk with setpriority is that it can possibly be used on a
different process. However, it is extremely unlikely that the
user that Elasticsearch is running as in production will have
been granted permission to call it. Running as root is banned
and it's an extra admin action to grant the privilege to any
other user and there is no good reason for it to have been
granted to the Elasticsearch user.