[ML] Round up data frame analytics memory estimates to next MB #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously data frame analytics memory estimates were rounded to the nearest kilobyte, but this results in excessive precision for large analyses. This changes the estimates to always be reported in whole megabytes, rounded up from the low level estimate. Closes elastic#1110 Closes elastic/elasticsearch#54506
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Apr 7, 2020
This change is to support the switch from kb to mb being made in elastic/ml-cpp#1126
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Apr 7, 2020
This change is to support the switch from kb to mb being made in elastic/ml-cpp#1126
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Apr 7, 2020
This change is to support the switch from kb to mb being made in elastic/ml-cpp#1126
|
retest |
2 similar comments
|
retest |
|
retest |
przemekwitek
approved these changes
Apr 7, 2020
| } | ||
|
|
||
| BOOST_AUTO_TEST_CASE(testEstimateMemoryUsageFor1000Rows) { | ||
| testEstimateMemoryUsage(1000, "403kB", "142kB", 0); | ||
| BOOST_AUTO_TEST_CASE(testEstimateMemoryUsageFor1000000Rows) { |
There was a problem hiding this comment.
nit: Test name is off by one 0
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Apr 7, 2020
Previously data frame analytics memory estimates were rounded to the nearest kilobyte, but this results in excessive precision for large analyses. This changes the estimates to always be reported in whole megabytes, rounded up from the low level estimate. Backport of elastic#1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously data frame analytics memory estimates were
rounded to the nearest kilobyte, but this results in
excessive precision for large analyses. This changes
the estimates to always be reported in whole megabytes,
rounded up from the low level estimate.
Closes #1110
Closes elastic/elasticsearch#54506