[7.x][ML] Fix macOS sandbox rules #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two rules were missing: 1. We were blocking our own SIGIO signals used to wake up blocking file reads. (This is quite nasty as this functionality is only used in edge cases.) 2. We were blocking the setpriority() calls made by nice(). I added the (debug deny) rule so that any blocked calls get logged to the system console. This makes it easier to see which rules are required but missing. I also changed the code style to match what our current style guide says. Backport of elastic#1146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two rules were missing:
file reads. (This is quite nasty as this functionality is only
used in edge cases.)
I added the (debug deny) rule so that any blocked calls get logged
to the system console. This makes it easier to see which rules are
required but missing.
I also changed the code style to match what our current style guide
says.
Backport of #1146