[ML] Boosted tree tidy ups #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
added
review
>non-issue
>refactoring
v8.0.0
:ml/DataFrameAnalysis
v7.8.0
labels
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Apr 23, 2020
tveasey
added a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1125, we no longer need to recover memory inside
CBoostedTreeLeafNodeStatisticsfor splits whose gain is less than zero. Dereferencing a row iterator has a cost and we should minimise the number of times we do it in performance sensitive code. Finally, a small refactor to suppress a variable shadowing warning.