[ML] Only log failure to ignore SIGPIPE once #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning if something stops SIGPIPE being ignored has always been deferred as the signal calls are made before main() has run. However, the place the warning was deferred to could result in it being logged many times because the deferred logging was in a method that could be called many times. This change moves that deferred logging to a dedicated method that can just be called once.
|
I labelled this |
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
May 12, 2020
The warning if something stops SIGPIPE being ignored has always been deferred as the signal calls are made before main() has run. However, the place the warning was deferred to could result in it being logged many times because the deferred logging was in a method that could be called many times. This change moves that deferred logging to a dedicated method that can just be called once. Backport of elastic#1221
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
May 12, 2020
The warning if something stops SIGPIPE being ignored has always been deferred as the signal calls are made before main() has run. However, the place the warning was deferred to could result in it being logged many times because the deferred logging was in a method that could be called many times. This change moves that deferred logging to a dedicated method that can just be called once. Backport of elastic#1221
droberts195
added a commit
that referenced
this pull request
May 12, 2020
The warning if something stops SIGPIPE being ignored has always been deferred as the signal calls are made before main() has run. However, the place the warning was deferred to could result in it being logged many times because the deferred logging was in a method that could be called many times. This change moves that deferred logging to a dedicated method that can just be called once. Backport of #1221
droberts195
added a commit
that referenced
this pull request
May 12, 2020
The warning if something stops SIGPIPE being ignored has always been deferred as the signal calls are made before main() has run. However, the place the warning was deferred to could result in it being logged many times because the deferred logging was in a method that could be called many times. This change moves that deferred logging to a dedicated method that can just be called once. Backport of #1221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning if something stops SIGPIPE being ignored has
always been deferred as the signal calls are made before
main() has run. However, the place the warning was deferred
to could result in it being logged many times because the
deferred logging was in a method that could be called many
times.
This change moves that deferred logging to a dedicated
method that can just be called once.