Skip to content

[ML] Fix flakey progress monitoring test #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented May 11, 2020

Fix an intermittent test failure.

The concurrent queue doesn't guaranty the order messages are written out so we can only asset that each phase gets a 100% complete message not that it is also the last message.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey tveasey merged commit 7277fbb into elastic:master May 11, 2020
@tveasey tveasey deleted the flakey-test branch May 11, 2020 15:16
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request May 11, 2020
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request May 11, 2020
tveasey added a commit that referenced this pull request May 12, 2020
tveasey added a commit that referenced this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants