[ML] Fix weights to maximize minimum recall for multiclass classification when the training data is missing classes #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
changed the title
valeriy42
approved these changes
May 15, 2020
|
This only failed with a gradle issue on aarch64, so I'm going to merge. |
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
May 15, 2020
…tion when the training data is missing classes (elastic#1239)
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
May 15, 2020
…tion when the training data is missing classes (elastic#1239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on from #1231.
We were still running into problems if the Java doesn't sample a class at all in the training data. This points to a problem with the stratified sampling implementation in Java, but we need to make the weight calculation defensive.
Since this is a correction to change #1113, which hasn't been released, I've marked this as a non-issue, but it must go out at the same time in 7.8.