-
Notifications
You must be signed in to change notification settings - Fork 64
[ML] Correcting model state min_version #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
droberts195
merged 2 commits into
elastic:master
from
droberts195:correct_model_state_min_version
Oct 26, 2020
Merged
[ML] Correcting model state min_version #1546
droberts195
merged 2 commits into
elastic:master
from
droberts195:correct_model_state_min_version
Oct 26, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The model state min_version should indicate the minimum node version required to restore the model state. This has not been updated since 6.4.0, meaning we have not had the intended protection against model states being used on nodes that are too old. This change updates the min_version to the correct version at present, which is 7.9.0 for latest state. Relates elastic#1545
tveasey
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, but LGTM.
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Oct 27, 2020
The model state min_version should indicate the minimum node version required to restore the model state. This has not been updated since 6.4.0, meaning we have not had the intended protection against model states being used on nodes that are too old. This change updates the min_version to the correct version at present, which is 7.9.0 for latest state. Backport of elastic#1546
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Oct 27, 2020
The model state min_version should indicate the minimum node version required to restore the model state. This has not been updated since 6.4.0, meaning we have not had the intended protection against model states being used on nodes that are too old. This change updates the min_version to the correct version at present, which is 7.9.0 for latest state. Backport of elastic#1546
This was referenced Oct 27, 2020
droberts195
added a commit
that referenced
this pull request
Oct 27, 2020
The model state min_version should indicate the minimum node version required to restore the model state. This has not been updated since 6.4.0, meaning we have not had the intended protection against model states being used on nodes that are too old. This change updates the min_version to the correct version at present, which is 7.9.0 for latest state. Backport of #1546
droberts195
added a commit
that referenced
this pull request
Oct 27, 2020
The model state min_version should indicate the minimum node version required to restore the model state. This has not been updated since 6.4.0, meaning we have not had the intended protection against model states being used on nodes that are too old. This change updates the min_version to the correct version at present, which is 7.9.0 for latest state. Backport of #1546
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 27, 2020
Copies the release note for elastic/ml-cpp#1546 to where it needs to be to get published
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 27, 2020
Copies the release note for elastic/ml-cpp#1546 to where it needs to be to get published
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model state min_version should indicate the minimum
node version required to restore the model state. This
has not been updated since 6.4.0, meaning we have not had
the intended protection against model states being used on
nodes that are too old. This change updates the
min_version to the correct version at present, which is
7.9.0 for latest state.
Relates #1545