Skip to content

[ML] Scale regularisers for final train #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Feb 19, 2021

As we move towards training for hyperparameter tuning on a small fraction of the data set and final training on more we will suffer issues with overfitting if we don't address the bias this introduces estimating regularisers. Interestingly, we already see a mismatch in train and test errors on larger data sets where we only use two-folds. I tested this correction, which is the one we use when we downsample, on a variety of data sets and we ended up with lower mismatch between train and test errors.

Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey tveasey merged commit 0614b01 into elastic:master Feb 23, 2021
@tveasey tveasey deleted the regularisation-adjustment-for-final-train branch February 23, 2021 18:05
@droberts195
Copy link
Contributor

This is labelled v7.13.0 but is not yet backported to the 7.x branch - please don't forget!

tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Mar 25, 2021
As we move towards training for hyperparameter tuning on a small fraction of the data set and final training on more
we will suffer issues with overfitting if we don't address the bias this introduces estimating regularisers. Interestingly,
we already see a mismatch in train and test errors on larger data sets where we only use two-folds. I tested this
correction, which is the one we use when we downsample, on a variety of data sets and we ended up with lower
mismatch between train and test errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants