[ML] Output max num trees in hyperparameters metadata #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
reviewed
Apr 22, 2021
tveasey
approved these changes
Apr 22, 2021
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Apr 26, 2021
We output max number trees as a hyperparameter in the model metadata and add a unit test to ensure that we achieve reproducible results when retraining a model with all hyperparameters specified. Fixes elastic#1853 .
tveasey
added a commit
that referenced
this pull request
Apr 26, 2021
…x setup (#1870) Following on from #1867, we can and should be imposing the minimum depth constraint to the hyperparameter search bounding box. This was incorrectly applied before and also fixes the issue with reproducibility based on user overrides. This is a bit cleaner than applying the constraint magically in the code to adjust hyperparameters.
valeriy42
pushed a commit
to valeriy42/ml-cpp
that referenced
this pull request
Apr 26, 2021
…x setup (elastic#1870) Following on from elastic#1867, we can and should be imposing the minimum depth constraint to the hyperparameter search bounding box. This was incorrectly applied before and also fixes the issue with reproducibility based on user overrides. This is a bit cleaner than applying the constraint magically in the code to adjust hyperparameters.
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Apr 26, 2021
We output max number trees as a hyperparameter in the model metadata and add a unit test to ensure that we achieve reproducible results when retraining a model with all hyperparameters specified. Fixes elastic#1853 .
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Apr 26, 2021
We output max number trees as a hyperparameter in the model metadata and add a unit test to ensure that we achieve reproducible results when retraining a model with all hyperparameters specified. Fixes elastic#1853 .
valeriy42
pushed a commit
to valeriy42/ml-cpp
that referenced
this pull request
Apr 26, 2021
…x setup (elastic#1870) Following on from elastic#1867, we can and should be imposing the minimum depth constraint to the hyperparameter search bounding box. This was incorrectly applied before and also fixes the issue with reproducibility based on user overrides. This is a bit cleaner than applying the constraint magically in the code to adjust hyperparameters.
This was referenced Apr 26, 2021
valeriy42
pushed a commit
to valeriy42/ml-cpp
that referenced
this pull request
Apr 26, 2021
…x setup (elastic#1870) Following on from elastic#1867, we can and should be imposing the minimum depth constraint to the hyperparameter search bounding box. This was incorrectly applied before and also fixes the issue with reproducibility based on user overrides. This is a bit cleaner than applying the constraint magically in the code to adjust hyperparameters.
valeriy42
added a commit
that referenced
this pull request
Apr 27, 2021
* [ML] Output max num trees in hyperparameters metadata (#1867) We output max number trees as a hyperparameter in the model metadata and add a unit test to ensure that we achieve reproducible results when retraining a model with all hyperparameters specified. Fixes #1853 . * [ML] Apply tree depth constraint to hyperparameter search bounding box setup (#1870) Following on from #1867, we can and should be imposing the minimum depth constraint to the hyperparameter search bounding box. This was incorrectly applied before and also fixes the issue with reproducibility based on user overrides. This is a bit cleaner than applying the constraint magically in the code to adjust hyperparameters. Co-authored-by: Tom Veasey <[email protected]>
valeriy42
added a commit
that referenced
this pull request
Apr 27, 2021
* [ML] Output max num trees in hyperparameters metadata (#1867) We output max number trees as a hyperparameter in the model metadata and add a unit test to ensure that we achieve reproducible results when retraining a model with all hyperparameters specified. Fixes #1853 . * [ML] Apply tree depth constraint to hyperparameter search bounding box setup (#1870) Following on from #1867, we can and should be imposing the minimum depth constraint to the hyperparameter search bounding box. This was incorrectly applied before and also fixes the issue with reproducibility based on user overrides. This is a bit cleaner than applying the constraint magically in the code to adjust hyperparameters. Co-authored-by: Tom Veasey <[email protected]>
valeriy42
added a commit
that referenced
this pull request
Apr 27, 2021
* [ML] Output max num trees in hyperparameters metadata (#1867) We output max number trees as a hyperparameter in the model metadata and add a unit test to ensure that we achieve reproducible results when retraining a model with all hyperparameters specified. Fixes #1853 . * [ML] Apply tree depth constraint to hyperparameter search bounding box setup (#1870) Following on from #1867, we can and should be imposing the minimum depth constraint to the hyperparameter search bounding box. This was incorrectly applied before and also fixes the issue with reproducibility based on user overrides. This is a bit cleaner than applying the constraint magically in the code to adjust hyperparameters. Co-authored-by: Tom Veasey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We output max number trees as a hyperparameter in the model metadata and add a unit test to ensure that we achieve reproducible results when retraining a model with all hyperparameters specified.
Fixes #1853 .