Skip to content

[6.7][ML] do not exit the worker after warning about failed cleanup #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/CHANGELOG.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ Fix cause of "Sample out of bounds" error message (See {ml-pull}355[355].}

=== Regressions

== {es} version 6.5.5

=== Bug Fixes

Fix a race condition if a forecast job requires overflowing to disk but cleanup of temporary
storage fails. This can cause the autodetect process to hang on exit, if more forecast requests
are in the queue. (See {ml-pull}352[352].)

== {es} version 6.5.3

=== Bug Fixes
Expand Down
1 change: 0 additions & 1 deletion lib/api/CForecastRunner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ void CForecastRunner::forecastWorker() {
LOG_WARN(<< "Failed to cleanup temporary data from: "
<< forecastJob.s_TemporaryFolder << " error "
<< errorCode.message());
return;
}
}
}
Expand Down