[ML] Threading optimisations #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts195
reviewed
Mar 5, 2019
include/core/Concurrency.h
Outdated
|
|
||
| return std::move(result); | ||
| return std::move(result); |
There was a problem hiding this comment.
The indenting looks a bit off here and in the 4 lines above - is what clang-format decided?
There was a problem hiding this comment.
Yes. I've seen this before when using brace initialiser with a lambda. I'll rejig and see if it improves the formatting.
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Mar 7, 2019
tveasey
added a commit
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping function calls in a
std::packaged_taskwas slightly more than doubling the runtime overhead per task in the thread pool. This moves to using a standard function pointer which can (optionally) hold the promise to which results are written. A nice side effect is we don't actually need a custom wrapper around std::future to unpack the result of function passed to the thread pool, so the code is slightly cleaner.