[ML] Replace boost functions by their std equivalents #508
Conversation
|
recheck |
There was a problem hiding this comment.
Thanks for doing this! It's a lot of files to change but certainly makes the code look much more modern.
I found a few more files that could probably also be changed:
bash-3.2$ find . -type f | xargs egrep 'boost::(array|begin|end|is_pod|ref|cref|make_unique|algorithm::is_sorted|bind)'
./lib/core/unittest/CBase64FilterTest.cc: filter.push(boost::ref(sink));
./lib/core/unittest/CBase64FilterTest.cc: filter.push(boost::ref(source));
./lib/core/unittest/CBase64FilterTest.cc: filter.push(boost::ref(sink));
./lib/core/unittest/CBase64FilterTest.cc: filter.push(boost::ref(sink));
./lib/core/unittest/CBase64FilterTest.cc: filter.push(boost::ref(source));
./lib/core/unittest/CBase64FilterTest.cc: filter.push(boost::ref(source));
./lib/core/CCompressOStream.cc: m_OutFilter.push(boost::ref(m_FilterSink));
./lib/core/CStateDecompressor.cc: m_InFilter->push(boost::ref(m_FilterSource));
./lib/api/CLengthEncodedInputParser.cc: // caused by boost::reference_wrapper not having a default
./lib/api/CLengthEncodedInputParser.cc: // some type of vector of boost::reference_wrappers.
Also, if you run this command from the top level of the ml-cpp repo it shows lots of places where the Boost headers are still included:
find . -type f | xargs egrep 'boost/(ref|make_unique|bind).hpp'
include/core/UnwrapRef.h
Outdated
| */ | ||
|
|
||
| #ifndef INCLUDE_CORE_UNWRAPREF_H_ | ||
| #define INCLUDE_CORE_UNWRAPREF_H_ |
There was a problem hiding this comment.
nit: following the pattern of all our other guards this would be INCLUDED_ml_core_UnwrapRef_h
(Note especially INCLUDED ending with D.)
|
|
||
| #include <functional> | ||
|
|
||
| namespace ml { |
There was a problem hiding this comment.
Please can you add a Doxygen comment. Something along the lines of:
//! Temporary substitute for std::unwrap_ref. This will be replaced by
//! std::unwrap_ref once all our compilers support it. The names in this
//! file do not conform to the coding style to ease the eventual transition
//! to std::unwrap_ref.
| @@ -785,7 +786,7 @@ void CMemoryUsageTest::testDynamicSizeAlwaysZero() { | |||
| CPPUNIT_ASSERT_EQUAL(haveStructPodCompilerSupport, test); | |||
| test = core::memory_detail::SDynamicSizeAlwaysZero<std::pair<int, int>>::value(); | |||
| CPPUNIT_ASSERT_EQUAL(true, test); | |||
| test = boost::is_pod<SFoo>::value; | |||
| test = std::is_pod<SFoo>::value; | |||
There was a problem hiding this comment.
You can now delete the comment on lines 762 to 770.
Also I imagine now haveStructPodCompilerSupport should always be true, so you could get rid of that too and replace with literal trues.
Sorry, I just realised this is why most of the extra places my first |
|
recheck |
* Replace boost functions with std where possible * UnwrapRef: Safeguard fix and documentation * CMemoryUsageTest.cc: get rid of outdated comment and is_pod checks * Remove superfluous includes * Fix windows compiler bug * Fix formatting * Added missing comment
Following boost functions have been raplaced with their std equivalents: boost::array, boost::begin, boost::end, boost::is_pod, boost::ref, boost::cref, boost::reference_wrapper, boost::make_unique, boost::algorithm::is_sorted, boost::bind. Due to the limitations of the std::ref implementation, boost::ref cannot be removed where it is used in Input and Output filters (e.g. lib/core/CCompressOStream.cc and lib/core/CStateDecompressor.cc).
Following boost functions have been raplaced with their std equivalents:
boost::array,boost::begin,boost::end,boost::is_pod,boost::ref,boost::cref,boost::reference_wrapper,boost::make_unique,boost::algorithm::is_sorted,boost::bind.Due to the limitations of the std::ref implementation, boost::ref cannot be removed where it is used in Input and Output filters (e.g.
lib/core/CCompressOStream.ccandlib/core/CStateDecompressor.cc).Fixes #337