[ML] Do not write model size stats after autodetect no-op #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Fixes elastic#394
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jun 27, 2019
Similar to elastic/ml-cpp#512, if a job opens and closes and does nothing in between we shouldn't write timing stats to the results index.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jun 27, 2019
If a job is opened and then closed and does nothing in between then it should not persist any results or state documents. This change adapts the no-op job test to assert no results in addition to no state, and to log any documents that cause this assertion to fail. Relates elastic/ml-cpp#512 Relates elastic#43680
|
The test for this is in elastic/elasticsearch#43681 |
|
retest |
1 similar comment
|
retest |
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of elastic#512
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of elastic#512
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of elastic#512
This was referenced Jun 27, 2019
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 27, 2019
Similar to elastic/ml-cpp#512, if a job opens and closes and does nothing in between we shouldn't write timing stats to the results index.
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 27, 2019
Similar to elastic/ml-cpp#512, if a job opens and closes and does nothing in between we shouldn't write timing stats to the results index.
droberts195
added a commit
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in #437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of #512
droberts195
added a commit
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in #437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of #512
droberts195
added a commit
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in #437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of #512
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 29, 2019
If a job is opened and then closed and does nothing in between then it should not persist any results or state documents. This change adapts the no-op job test to assert no results in addition to no state, and to log any documents that cause this assertion to fail. Relates elastic/ml-cpp#512 Relates #43680
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 29, 2019
If a job is opened and then closed and does nothing in between then it should not persist any results or state documents. This change adapts the no-op job test to assert no results in addition to no state, and to log any documents that cause this assertion to fail. Relates elastic/ml-cpp#512 Relates #43680
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 29, 2019
If a job is opened and then closed and does nothing in between then it should not persist any results or state documents. This change adapts the no-op job test to assert no results in addition to no state, and to log any documents that cause this assertion to fail. Relates elastic/ml-cpp#512 Relates #43680
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 29, 2019
If a job is opened and then closed and does nothing in between then it should not persist any results or state documents. This change adapts the no-op job test to assert no results in addition to no state, and to log any documents that cause this assertion to fail. Relates elastic/ml-cpp#512 Relates #43680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the fix for state and quantiles in #437,
if no input is received and time is not advanced then
there is no need to write model size stats when the
autodetect process exits. Doing this can actually
cause a problem for a job that has never ever seen
any input, as the unnecessary model size stats were
written with a negative timestamp. This change also
adds an extra defensive check to prevent that ever
happening, although the only situation when it is
thought to be possible should be prevented by the
first change.
Fixes #394