Introduce memory usage estimation mode in data_frame_analyzer #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
model_memory_limit
branch
4 times, most recently
from
1a97d9c to
978a6b4
Compare
tveasey
reviewed
Aug 6, 2019
przemekwitek
force-pushed
the
model_memory_limit
branch
from
978a6b4 to
c73e021
Compare
…ory estimations but does not perform any analysis
przemekwitek
force-pushed
the
model_memory_limit
branch
from
c73e021 to
462023d
Compare
Thanks. I've just sent this PR to regular review and will address your comments shortly. |
tveasey
approved these changes
Aug 7, 2019
There was a problem hiding this comment.
Good stuff! This looks good to go. Just a couple of comment typos and a suggestion. Also, I propose we use the usual error handling mechanism for dealing with the case that the runner is null. I'm going to go ahead and approve because I don't think this needs any further reviews.
droberts195
reviewed
Aug 7, 2019
…than long values (representing bytes).
przemekwitek
added a commit
to przemekwitek/ml-cpp
that referenced
this pull request
Aug 7, 2019
przemekwitek
added a commit
that referenced
this pull request
Aug 7, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a mode in which data_frame_analyzer binary only outputs memory usage estimations but does not perform any analysis. This mode will be used by the new endpoint in Java server.
Relates elastic/elasticsearch#44699