Skip to content

[ML] Allow configuration of prediction column name in data_frame_analyzer #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2019
Merged

[ML] Allow configuration of prediction column name in data_frame_analyzer #587

merged 3 commits into from
Aug 7, 2019

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Aug 6, 2019

Plus a better default.

dimitris-athanasiou
dimitris-athanasiou reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a suggestion for changing the name of prediction_column_name.

dimitris-athanasiou
dimitris-athanasiou approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey tveasey merged commit e527aaa into elastic:master Aug 7, 2019
@tveasey tveasey deleted the configurable-prediction-name branch August 7, 2019 13:54
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Aug 8, 2019
@tveasey
[ML] Allow configuration of prediction column name in data_frame_anal…
eee4d66 
…yzer (elastic#587)
@tveasey tveasey mentioned this pull request Aug 8, 2019
Merged
tveasey added a commit that referenced this pull request Aug 8, 2019
@tveasey
[7.4][ML] Allow configuration of prediction column name in data_frame…
9720572 
…_analyzer (#589)

Backport #587.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
:ml/DataFrameAnalysis >non-issue review v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tveasey @dimitris-athanasiou