Skip to content

[7.x][ML] Rename standardize_columns to standardization_enabled (#716) #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2019
Merged

[7.x][ML] Rename standardize_columns to standardization_enabled (#716) #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/api/CDataFrameOutliersRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class API_EXPORT CDataFrameOutliersRunner final : public CDataFrameAnalysisRunne
std::size_t m_Method;

//! If true then standardise the feature values.
bool m_StandardizeColumns = true;
bool m_StandardizationEnabled = true;

//! Compute the significance of features responsible for each point being outlying.
bool m_ComputeFeatureInfluence = true;
Expand Down
10 changes: 5 additions & 5 deletions lib/api/CDataFrameOutliersRunner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace ml {
namespace api {
namespace {
// Configuration
const std::string STANDARDIZE_COLUMNS{"standardize_columns"};
const std::string STANDARDIZATION_ENABLED{"standardization_enabled"};
const std::string N_NEIGHBORS{"n_neighbors"};
const std::string METHOD{"method"};
const std::string COMPUTE_FEATURE_INFLUENCE{"compute_feature_influence"};
Expand All @@ -40,7 +40,7 @@ const CDataFrameAnalysisConfigReader PARAMETER_READER{[] {
const std::string knn{"distance_kth_nn"};
const std::string tnn{"distance_knn"};
CDataFrameAnalysisConfigReader theReader;
theReader.addParameter(STANDARDIZE_COLUMNS,
theReader.addParameter(STANDARDIZATION_ENABLED,
CDataFrameAnalysisConfigReader::E_OptionalParameter);
theReader.addParameter(N_NEIGHBORS, CDataFrameAnalysisConfigReader::E_OptionalParameter);
theReader.addParameter(METHOD, CDataFrameAnalysisConfigReader::E_OptionalParameter,
Expand All @@ -66,7 +66,7 @@ CDataFrameOutliersRunner::CDataFrameOutliersRunner(
const CDataFrameAnalysisConfigReader::CParameters& parameters)
: CDataFrameOutliersRunner{spec} {

m_StandardizeColumns = parameters[STANDARDIZE_COLUMNS].fallback(true);
m_StandardizationEnabled = parameters[STANDARDIZATION_ENABLED].fallback(true);
m_NumberNeighbours = parameters[N_NEIGHBORS].fallback(std::size_t{0});
m_Method = parameters[METHOD].fallback(maths::COutliers::E_Ensemble);
m_ComputeFeatureInfluence = parameters[COMPUTE_FEATURE_INFLUENCE].fallback(true);
Expand Down Expand Up @@ -113,7 +113,7 @@ void CDataFrameOutliersRunner::runImpl(const TStrVec&, core::CDataFrame& frame)

maths::COutliers::SComputeParameters params{this->spec().numberThreads(),
this->numberPartitions(),
m_StandardizeColumns,
m_StandardizationEnabled,
static_cast<maths::COutliers::EMethod>(m_Method),
m_NumberNeighbours,
m_ComputeFeatureInfluence,
Expand All @@ -138,7 +138,7 @@ CDataFrameOutliersRunner::estimateBookkeepingMemoryUsage(std::size_t numberParti
std::size_t numberColumns) const {
maths::COutliers::SComputeParameters params{this->spec().numberThreads(),
numberPartitions,
m_StandardizeColumns,
m_StandardizationEnabled,
static_cast<maths::COutliers::EMethod>(m_Method),
m_NumberNeighbours,
m_ComputeFeatureInfluence,
Expand Down