-
Notifications
You must be signed in to change notification settings - Fork 64
Remove duplicated code. #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated code. #799
Conversation
There's nothing wrong with this change, but I don't think it will fix any bugs. It removes 3 lines of duplicated code, and it's nice to avoid code duplication so I'm happy to merge it. But the duplicated code that's removed is just the definition of a lambda, not calling that lambda. So there wasn't any double wrapping of streams before. So, like I say, I'm happy for this change to be made but it won't help with elastic/elasticsearch#47612 and therefore the commit message should not reference that issue. The commit title should just be something like "Remove duplicated code". |
f77e12f
to
311ccb4
Compare
I've changed the title and description of this PR to reflect that it is only about deduplicating code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove duplicated code in
bin/data_frame_analyzer/Main.cc