Skip to content

[ML] Tweak CBoostedTreeTest.testLogisticRegression test threshold further #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

droberts195
Copy link
Contributor

The older version of clang used on the 7.x El Capitan reference
build server creates an actual value of 0.51796218392671234, so
increase the threshold to 0.52

…ther

The older version of clang used on the 7.x El Capitan reference
build server creates an actual value of 0.51796218392671234, so
increase the threshold to 0.52
Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 62e430e into elastic:master Dec 11, 2019
@droberts195 droberts195 deleted the tweak_test_threshold branch December 11, 2019 11:35
droberts195 added a commit to droberts195/ml-cpp that referenced this pull request Dec 11, 2019
…ther (elastic#887)

The older version of clang used on the 7.x El Capitan reference
build server creates an actual value of 0.51796218392671234, so
increase the threshold to 0.52
droberts195 added a commit that referenced this pull request Dec 11, 2019
…ther

The older version of clang used on the 7.x El Capitan reference
build server creates an actual value of 0.51796218392671234, so
increase the threshold to 0.52

Backport of #887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants