Add token based authn documentation in stack docs #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds documentation for token based authentication services like token-service and api-key-service.
jkakavas
reviewed
Feb 1, 2019
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Show resolved
Hide resolved
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
Co-Authored-By: bizybot <[email protected]>
Co-Authored-By: bizybot <[email protected]>
- add example usage for Authorization headers of Bearer and ApiKey schemes
…uthn-services-documentation
jaymode
reviewed
Feb 4, 2019
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
|
I'm fine with the content, but I will let @lcawl have the final say |
Co-Authored-By: bizybot <[email protected]>
Co-Authored-By: bizybot <[email protected]>
Co-Authored-By: bizybot <[email protected]>
lcawl
reviewed
Feb 5, 2019
lcawl
reviewed
Feb 5, 2019
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
|
I copied the intro from the new token-based authentication page to the existing "realms" page too. |
bizybot
changed the base branch from
api-key-service-stack-documentation
to
master
bizybot
changed the base branch from
master
to
api-key-service-stack-documentation
added 2 commits
February 6, 2019 16:37
…uthn-services-documentation
bizybot
changed the base branch from
api-key-service-stack-documentation
to
master
lcawl
reviewed
Feb 6, 2019
lcawl
reviewed
Feb 6, 2019
lcawl
reviewed
Feb 6, 2019
lcawl
reviewed
Feb 6, 2019
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
lcawl
reviewed
Feb 6, 2019
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
lcawl
reviewed
Feb 6, 2019
Co-Authored-By: bizybot <[email protected]>
Co-Authored-By: bizybot <[email protected]>
Co-Authored-By: bizybot <[email protected]>
Co-Authored-By: bizybot <[email protected]>
Co-Authored-By: bizybot <[email protected]>
|
Hi @lcawl, I have accepted your suggested changes and addressed the review comments. |
lcawl
reviewed
Feb 6, 2019
docs/en/stack/security/authentication/token-authentication-services.asciidoc
Outdated
Show resolved
Hide resolved
lcawl
approved these changes
Feb 6, 2019
bizybot
added a commit
to bizybot/stack-docs
that referenced
this pull request
Feb 7, 2019
This commit adds documentation for token-based authentication services like token-service and api-key-service.
bizybot
added a commit
that referenced
this pull request
Feb 7, 2019
bizybot
added a commit
to bizybot/stack-docs
that referenced
this pull request
Feb 8, 2019
This commit adds documentation for token-based authentication services like token-service and api-key-service.
bizybot
added a commit
that referenced
this pull request
Feb 8, 2019
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds documentation for token-based
authentication services like token-service and
api-key-service. The overview section mentions
the token-based authentication services and a separate
page has information on
token-serviceandapi-key-servicementioned in the order they are consulted for authentication.
The links for the API keys from Elasticsearch reference are not yet
on master but on the api-key-service feature branch.