Skip to content

[DOCS] Added Data Frames subsection to ML section. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 12, 2019

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented May 30, 2019

This PR adds a Data Frames overview subsection to the ML section.

@szabosteve szabosteve requested a review from lcawl May 30, 2019 14:03
@szabosteve szabosteve requested a review from hendrikmuhs May 31, 2019 15:56
@szabosteve szabosteve marked this pull request as ready for review May 31, 2019 15:56
@pheyos
Copy link
Member

pheyos commented Jun 7, 2019

Would this documentation be the right place to mention the needed permissions around the whole data frame topic? Asking, because I currently can't find it anywhere and users might think machine_learning_admin might be the required role (since data frames are located under ML), which is not the case.

@lcawl
Copy link
Contributor

lcawl commented Jun 7, 2019

@pheyos We typically add that type of information in the API reference material, but you're right I don't see it in https://www.elastic.co/guide/en/elasticsearch/reference/master/put-data-frame-transform.html for example. I'll follow-up and add it there and potentially in the (upcoming) configuration example too.

@pheyos
Copy link
Member

pheyos commented Jun 7, 2019

thanks @lcawl !

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, but otherwise LGTM and builds successfully

@szabosteve szabosteve merged commit 9a58dfa into elastic:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants