Skip to content

[DOCS] Adds Kibana expiration behaviour #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 14, 2019

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit. Maybe add a period at the end of the first two bullet points to be consistent with the third bullet?

@lcawl
Copy link
Contributor Author

lcawl commented Nov 14, 2019

Thanks for the feedback, @gchaps! I've added punctuation throughout the page and got rid of the future tense while I was at it.

@lcawl lcawl merged commit a53eef1 into elastic:master Nov 15, 2019
@lcawl lcawl deleted the expiring-kibana branch November 15, 2019 00:15
@lcawl lcawl added the v7.4.3 label Nov 15, 2019
lcawl added a commit that referenced this pull request Nov 15, 2019
lcawl added a commit that referenced this pull request Nov 15, 2019
lcawl added a commit that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update license expiration docs to include details about what happens in Kibana
2 participants