Skip to content

build(dev-deps): update vitest to 3.0.6 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2025
Merged

build(dev-deps): update vitest to 3.0.6 #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb43801
build(dev-deps): update vitest to 3.0.6
dsanders11 Feb 22, 2025
bef0980
test: bump default timeout
dsanders11 Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"markdownlint-cli2": "^0.14.0",
"prettier": "^3.2.5",
"typescript": "^5.4.5",
"vitest": "^2.1.4"
"vitest": "^3.0.6"
},
"dependencies": {
"@dsanders11/vscode-markdown-languageservice": "^0.3.0",
Expand Down
8 changes: 8 additions & 0 deletions vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/// <reference types="vitest/config" />
import { defineConfig } from 'vitest/config';
Comment on lines +1 to +2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the reference to vitest/config is only necessary when importing defineConfig from vite, we don't need it when we're already importing that type directly:

Suggested change
/// <reference types="vitest/config" />
import { defineConfig } from 'vitest/config';
import { defineConfig } from 'vitest/config';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. I also thought that was odd, but I think @erickzhao and I got confused by the docs, see https://github.com/electron/forge/pull/3797/files#r1909540910. The docs link in those comments is dead now, but I see what you're referring to in the current docs. Good to know going forward, we'll clean them up. Thanks @erikian!


export default defineConfig({
test: {
testTimeout: 30_000,
},
});
Loading
Loading