-
-
Notifications
You must be signed in to change notification settings - Fork 47
Issue/createroom api behavior does not match spec #3562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tristianc
wants to merge
4
commits into
element-hq:main
Choose a base branch
from
tristianc:issue/createroom-api-behavior-does-not-match-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue/createroom api behavior does not match spec #3562
tristianc
wants to merge
4
commits into
element-hq:main
from
tristianc:issue/createroom-api-behavior-does-not-match-spec
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esent and visibility are unset
kegsay
reviewed
May 16, 2025
guestsCanJoin = true | ||
case "public": | ||
joinRuleContent.JoinRule = spec.Public | ||
historyVisibilityContent.HistoryVisibility = historyVisibilityShared |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer it if you just set the createRequest.StatePreset
rather than re-implement the state preset code here.
i.e:
// If unspecified, the server should use the visibility
// to determine which preset to use.
// A visibility of public equates to a preset of public_chat
// and private visibility equates to a preset of private_chat.
if createRequest.StatePreset == "" {
switch createRequest.Visibility {
// Rooms default to private visibility if this key is not included.
case "private", "":
createRequest.StatePreset = "private_chat"
case "public":
createRequest.StatePreset = "public_chat"
}
}
switch createRequest.StatePreset {
// ... rest of code
kegsay
requested changes
May 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Instead, if the StatePreset is unset, set it based on the Visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Signed-off-by:
Tristian Celestin <[email protected]>