Live sessions list #1905
Merged
Live sessions list #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
Aug 12, 2020
| .map { it.userId } | ||
| ).distinct() | ||
| val usersList = (deviceInfoList.map { it.userId } + signingKeyInfoList.map { it.userId }) | ||
| .distinct() |
bmarty
commented
Aug 12, 2020
| .throttleLast(5_000, TimeUnit.MILLISECONDS) | ||
| .map { it.size } | ||
| .distinctUntilChanged() | ||
| .throttleFirst(5_000, TimeUnit.MILLISECONDS) |
There was a problem hiding this comment.
I think that I made it to wait a bit mainly for the first time. If not just after a new session you could have verification alerts coming to fast
to merge
Rx: use distinctUntilChanged() instead of distinct()
bmarty
force-pushed
the
feature/refresh_device_list
branch
from
172248c to
7a2454d
Compare
bmarty
commented
Aug 13, 2020
| .map { it.userId } | ||
| ).distinct() | ||
| val usersList = (deviceInfoList.map { it.userId } + signingKeyInfoList.map { it.userId }) | ||
| .distinct() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When another session was remotely deleted (i.e. signed out), the session list was not updating correctly.
Fix other RX similar issues.
First commit is just a renaming