"Close" button for user sidebar actually brings up user list

[jdm]

Description

When I click on a user's avatar in a room, it brings up the user sidebar. When I press the button labeled close in order to close this sidebar, it gets replaced with the room member list. I then have to press the "Members" button to hide this sidebar.

Steps to reproduce

• click on an avatar in a room
• click on the sidebar's close button

My expectation is that pressing the button labeled "Close" will cause the room to return to its state from before I clicked on the avatar.

Logs being sent: no

Base room state, about to click on stas' avatar:

Before pressing the "<" button labelled "Close":

After pressing the "<" button labelled "Close":

Version information

• Platform: web (in-browser)

For the web app:

• Browser: Firefox 74 (nightly)
• OS: macOS 10.14
• URL: chat.mozilla.org

[michal-weglarz]

At this point I find it very confusing what that button is intended to do. It tells user neither to collapse sidepanel (I'd expect the arrow to be turned the other way- to the right: ">"), nor to display list of all users in a room (its label says "Close"). It kind of contradicts itself and there should be made some decision what's the real intention and deliver it to the end user more clearly. Anyway, It looks like it's more of a displaying all room's members than closing sidebar entirely so I'd opt for changing the label.

[t3chguy]

It's intended to close the User Info panel, and reveal the Member List panel below it, but in your case you're right the Member List should not be waiting there below it.

[t3chguy]

Fixed by matrix-org/matrix-react-sdk#5167