Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Right Panel Room Summary and Widgets #5167

Merged
merged 35 commits into from
Sep 9, 2020
Merged

Right Panel Room Summary and Widgets #5167

merged 35 commits into from
Sep 9, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 3, 2020

@t3chguy t3chguy marked this pull request as ready for review September 7, 2020 18:13
@t3chguy t3chguy marked this pull request as draft September 7, 2020 18:13
@t3chguy t3chguy force-pushed the t3chguy/dpsah/6785.1 branch from ee8a6b4 to 1466515 Compare September 7, 2020 18:19
Base automatically changed from t3chguy/dpsah/6785 to develop September 8, 2020 08:47
@t3chguy t3chguy force-pushed the t3chguy/dpsah/6785.1 branch from 41435c7 to 0c08448 Compare September 8, 2020 11:02
@turt2live turt2live changed the title T3chguy/dpsah/6785.1 Widget base Sep 8, 2020
@t3chguy t3chguy changed the title Widget base Right Panel Room Summary and Widgets Sep 8, 2020
@t3chguy t3chguy force-pushed the t3chguy/dpsah/6785.1 branch from 6c12fb5 to 8d14d26 Compare September 8, 2020 15:27
@t3chguy t3chguy marked this pull request as ready for review September 8, 2020 15:34
@t3chguy t3chguy requested a review from a team September 8, 2020 15:34
@t3chguy t3chguy added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Sep 8, 2020
@turt2live turt2live removed the request for review from a team September 8, 2020 15:34
@t3chguy t3chguy requested review from a team September 8, 2020 17:28
@turt2live
Copy link
Member

Some bugs with the adhoc build:

  • The files card in Element Web Internal causes the composer to go missing/get cut off

.. and that's pretty much it.

@t3chguy t3chguy added the blocked label Sep 8, 2020
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t3chguy @benedikrok this is really exciting! One thing which feels off in this PR is having the [i] icon not be the last in the row, as it breaks the spatial relationship with the card. Couple of questions/thoughts:

1/ Do we have an immediate plan scoped for the RC this will ship with for moving the Notifications bell to be a more global interaction (e.g. near the username, revealing notifications in a tooltip)?
2/ If not, could we invert the order of the icons to ensure the [i] icon is always last with this PR?

Otherwise feeling great!

@t3chguy
Copy link
Member Author

t3chguy commented Sep 9, 2020

Do we have an immediate plan scoped for the RC this will ship with for moving the Notifications bell to be a more global interaction (e.g. near the username, revealing notifications in a tooltip)?

Not for this RC. Redoing Notifications sounds more like an FTUE Notifications project.

@t3chguy
Copy link
Member Author

t3chguy commented Sep 9, 2020

@nadonomy Sorry for ignoring your review but we are going to have to merge now and fix copy later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants