-
-
Notifications
You must be signed in to change notification settings - Fork 823
Conversation
ee8a6b4
to
1466515
Compare
41435c7
to
0c08448
Compare
6c12fb5
to
8d14d26
Compare
Some bugs with the adhoc build:
.. and that's pretty much it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t3chguy @benedikrok this is really exciting! One thing which feels off in this PR is having the [i] icon not be the last in the row, as it breaks the spatial relationship with the card. Couple of questions/thoughts:
1/ Do we have an immediate plan scoped for the RC this will ship with for moving the Notifications bell to be a more global interaction (e.g. near the username, revealing notifications in a tooltip)?
2/ If not, could we invert the order of the icons to ensure the [i] icon is always last with this PR?
Otherwise feeling great!
Not for this RC. Redoing Notifications sounds more like an FTUE Notifications project. |
@nadonomy Sorry for ignoring your review but we are going to have to merge now and fix copy later. |
Adhoc build at https://riots.im/adhoc/dpsah-right-panel-widgets3/