Skip to content

Clicking "Favourite" or "Low priority" in the room options title dropdown menu doesn't update the label #19776

Closed
matrix-org/matrix-react-sdk
#7154
@anoadragon453

Description

@anoadragon453

Clicking on the "Favourite" or "Low priority" menu items in the new room options dropdown menu doesn't update said menu item. The room favourite status is modified, but the menu item copy is only updated upon loading the menu.

2021-11-17.00-18-54.mp4

I suspect this is because when using the existing implementation of right-clicking a room in the room list sidebar, and then clicking "Favourite" or "Low priority", the menu would disappear.

But since the room options menu hangs around, the menu item appears to not update.

I prefer the menu hanging around for these options however - allowing one to easily unfavourite a room if they did so accidentally. But it seems that we're missing a re-render here.

Operating system

Arch Linux

Browser information

Firefox Nightly 96.0a1

URL for webapp

develop.element.io

Application version

Element version: b2e8f21-react-ac15661c3e04-js-af523522def0

Homeserver

No response

Will you send logs?

No

Metadata

Metadata

Assignees

Labels

A-Room-ListA-Room-ViewO-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MinorImpairs non-critical functionality or suitable workarounds existT-Defect

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions