Skip to content

Test: don't unmount MatrixChat before setup is finished #25783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jul 13, 2023

Failure ex: https://github.com/matrix-org/matrix-react-sdk/actions/runs/5538102798/jobs/10107690836?pr=11249

  1. Loading test mounts MatrixChat
  2. MatrixChat starts doing a lot of setup
  3. Loading test doesn't wait for setup to finish
  4. test cleanup unmounts MatrixChat, which unsets MatrixClient on MatrixClientPeg
  5. MatrixChat continues setting up and tries to use an unset client from MatrixClientPeg.get()

Adds more waiting to loading test to avoid unmounting before app startup settles.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kerryarchibald kerryarchibald merged commit e68583a into develop Jul 16, 2023
@kerryarchibald kerryarchibald deleted the kerry/more-wait-in-loading-test branch July 16, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants