Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reporting a room when rejecting an invite. #29570

Merged
merged 37 commits into from
Apr 8, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Mar 21, 2025

This adds the ability report a room when declining an invite.

Design

This:

  • Changes the language in the app from "Reject" to "Decline" for invites.
  • Adds a third option on the room invite view to decline & block.

Screenshots

screenshot

@@ -709,36 +709,6 @@ export default class MatrixChat extends React.PureComponent<IProps, IState> {
case "copy_room":
this.copyRoom(payload.room_id);
break;
case "reject_invite":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is unused.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the class component conversion

@Half-Shot
Copy link
Member Author

Thanks for doing the class component conversion

I failed to explain why, but for whatever reason secureRandomString was giving me undefined in my tests. React's getId() was not, so this was a cheeky way to sidestep the problem a bit. I don't know if that's a bad smell, but more functional components is probably a good thing.

@Half-Shot Half-Shot requested a review from dbkr April 3, 2025 13:44
@Half-Shot Half-Shot added this pull request to the merge queue Apr 8, 2025
Merged via the queue into develop with commit 8fc6638 Apr 8, 2025
32 checks passed
@Half-Shot Half-Shot deleted the hs/report-room-on-invite branch April 8, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants