Skip to content

Implement MSC4155: Invite filtering #29603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Implement MSC4155: Invite filtering #29603

wants to merge 14 commits into from
+310 −1

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Mar 27, 2025 •
edited
Loading

This makes use of a server-side component element-hq/synapse#18288
Implements configuration piece of matrix-org/matrix-spec-proposals#4155

image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@Half-Shot Half-Shot mentioned this pull request Mar 27, 2025
Open
@Half-Shot Half-Shot mentioned this pull request May 29, 2025
Merged
1 task
@Half-Shot Half-Shot marked this pull request as ready for review June 2, 2025 10:25
@Half-Shot Half-Shot requested a review from a team as a code owner June 2, 2025 10:25
MidhunSureshR
MidhunSureshR approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably write any new UI code in MVVM style.

src/components/views/settings/InviteControlsPanel.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that we're relying on the server to do the actual blocking, we should also check m.invite_permission_config_enforced.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

@Half-Shot Half-Shot removed the request for review from t3chguy June 2, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR approved these changes

Assignees
No one assigned
Labels
T-Enhancement X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @MidhunSureshR