Skip to content

Geometry types #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Nov 21, 2019
Merged

Geometry types #88

merged 34 commits into from
Nov 21, 2019

Conversation

jeroenbourgois
Copy link
Contributor

Hip Hop Hurray! Thanks to awesome input from @wojtekmach and some plumbing on beforehand from our part, we landed a good basis for geo support in MyXQL! Already in use in production!

Hope this can get into master soon, some other folks are waiting on it, and then it can get tested some more.

Regards
Jack + Joe (and @wojtekmach !)

@jeroenbourgois jeroenbourgois mentioned this pull request Nov 19, 2019
Closed
wojtekmach
wojtekmach reviewed Nov 19, 2019
View reviewed changes
Copy link
Member

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help with this! I left a few comments below.

@wojtekmach wojtekmach changed the title Wm geometry Geometry types Nov 19, 2019
@wojtekmach
Copy link
Member

Forgot to mention...

Already in use in production!

That's fantastic news!

@wojtekmach
Copy link
Member

@jeroenbourgois oh, I didn't notice you've opened this branch against mine! If it's not too much trouble, would you mind changing base branch to master? (or just opening a new PR if that's easier)

Oh, and if you want to do the honours and remove https://github.com/elixir-ecto/myxql/blame/master/MARIAEX_COMPATIBILITY.md#L41 - by all means :D Thanks again for your help with this!

@jeroenbourgois
Copy link
Contributor Author

@wojtekmach ok, will do, somewhere tonight probably.

@jeroenbourgois
Copy link
Contributor Author

jeroenbourgois commented Nov 20, 2019 •
edited
Loading

@jeroenbourgois oh, I didn't notice you've opened this branch against mine! If it's not too much trouble, would you mind changing base branch to master? (or just opening a new PR if that's easier)

Oh, and if you want to do the honours and remove https://github.com/elixir-ecto/myxql/blame/master/MARIAEX_COMPATIBILITY.md#L41 - by all means :D Thanks again for your help with this!

Would I ?! 😃 I'll keep this as last.

jeroenbourgois
jeroenbourgois commented Nov 20, 2019
View reviewed changes
Copy link
Contributor Author

@jeroenbourgois jeroenbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@jeroenbourgois
Copy link
Contributor Author

@wojtekmach too bad, all but the mariadb CI builds pass... :(

@wojtekmach
Copy link
Member

@jeroenbourgois there're only 2 things left

  1. please add me to your fork as a collaborator so that I can push to your branch, I have a couple minor fixes ready to apply

  2. please change the base branch of this PR to master

and that's it!

@jeroenbourgois jeroenbourgois changed the base branch from wm-geometry to master November 21, 2019 05:50
@jeroenbourgois
Copy link
Contributor Author

@wojtekmach done, and done!

@wojtekmach wojtekmach merged commit accc987 into elixir-ecto:master Nov 21, 2019
@wojtekmach
Copy link
Member

Thanks to everyone who helped with it!

@wojtekmach wojtekmach mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmach wojtekmach wojtekmach left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeroenbourgois @wojtekmach