Skip to content

mix deps.update should propagate dependencies #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josevalim opened this issue May 8, 2013 · 4 comments · Fixed by #1068
Closed

mix deps.update should propagate dependencies #1036

josevalim opened this issue May 8, 2013 · 4 comments · Fixed by #1068

Comments

@josevalim
Copy link
Member

If I update dependency :a and :b depends on :a, :b should be recompiled by default (otherwise someone doing a full checkout can get a different result).

@ericmj
Copy link
Member

ericmj commented May 9, 2013

deps.compile should also propagate, right?

This should probably be implemented after caching of dependencies is added. If we could store all dependencies as a tree this issue would be trivial to implement.

@josevalim
Copy link
Member Author

You are right. What I had in mind was simply to store the deps of each project inside Mix.Dep. So after calling Mix.Deps.all, it would be easy to loop recursively checking everyone that depends on X.

If we really want the tree, we could implement it and have it spit out an iterator whenever we want to iterate it. :)

@ericmj
Copy link
Member

ericmj commented May 9, 2013

Ok, the tree can just as well be inline in the current data structure - no need to make an explicit tree.

@josevalim
Copy link
Member Author

That's kind of what we have right now but it would still require you to go through multiple loops in order to get all affected dependencies because the flat structure has no idea of nesting (we just know they are properly ordered).

ericmj added a commit to ericmj/elixir that referenced this issue May 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants