Use printf instead of echo to output flags #12704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: elixir-lang#12677 using printf here prevents an error when outputting the filtered flag `-e` as doing with with `echo "-e"` doesn't output anything (deleting the option we wanted to filter). This is explained here better than I ever could: https://unix.stackexchange.com/a/65819
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jun 23, 2023
Fixes #12677. Using printf here prevents an error when outputting the filtered flag `-e` as doing with with `echo "-e"` doesn't output anything (deleting the option we wanted to filter). More info: https://unix.stackexchange.com/a/65819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12677
using printf here prevents an error when outputting the filtered flag
-eas doing this withecho "-e"doesn't output anything (deleting the option we wanted to filter).This is explained here better than I ever could: https://unix.stackexchange.com/a/65819