Skip to content

elixir.bat: Quote file paths #13172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

wojtekmach
Copy link
Member

Before this patch, if any of the boot paths contained spaces we got a failure:

image

This was also the cause of livebook-dev/livebook#2368.

Note we are also quoting non-path values as cookies for consistency so I double-checked and that is not problematic:

C:\Users\User\foo bar\foo>iex --sname foo --cookie bar
Erlang/OTP 26 [erts-14.1.1] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [jit:ns]

Interactive Elixir (1.15.7) - press Ctrl+C to exit (type h() ENTER for help)
iex(foo@WinDev2206Eval)1> Node.get_cookie
:bar

@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

josevalim pushed a commit that referenced this pull request Dec 12, 2023
@wojtekmach wojtekmach deleted the wm-windows-quote branch December 12, 2023 13:33
@wojtekmach
Copy link
Member Author

@josevalim should we back port this to v1.15?

@josevalim
Copy link
Member

josevalim commented Dec 29, 2023

There won't be a new Elixir v1.15 release. If your concern is Livebook, perhaps we can temporarily patch it there?

@wojtekmach
Copy link
Member Author

Oh, ok. There's no rush. I'm updating Livebook to 1.16 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants