Run the code formatter on Mix.Tasks.Compile.App #6663
Conversation
| Keyword.get(opts, :app, true), | ||
| Keyword.get(opts, :runtime, true), | ||
| not Keyword.get(opts, :optional, false), | ||
| app not in included_applications, | ||
| do: app | ||
| app not in included_applications, do: app |
There was a problem hiding this comment.
I'm not sure about location do block on one line with condition
There was a problem hiding this comment.
Good catch. This is a bug. I will investigate!
| Mix.raise "Application description (:description) is not a character list, got: #{inspect value}" | ||
| Mix.raise( | ||
| "Application description (:description) is not a character list, got: #{ | ||
| inspect(value) |
There was a problem hiding this comment.
And I'm not sure about such splits of long lines with variables. How best to do in such cases?
There was a problem hiding this comment.
msg = "Application description (:description) is not a character list, got: #{inspect(value)}"
or if it still doesn't fit, break using <>:
"Application description (:description) is not a character list, " <>
"got: #{inspect(value)}"
|
Thanks @Nitrino! For the cases where the interpolation broke apart, it is best to use the concatenation operators. Regarding the |
|
Hi @Nitrino! I have pushed a fix to master for your long comprehension. Please rebase on latest master, run |
Nitrino
force-pushed
the
format_compile_app
branch
3 times, most recently
from
bdd5975 to
8c43b96
Compare
Nitrino
force-pushed
the
format_compile_app
branch
from
8c43b96 to
a03aa0a
Compare
|
@josevalim, after rebasing from master with your fix and recompile, formatter still thinks that |
|
@Nitrino I have tried it locally and it worked. So I will merge it here and fix it locally but meanwhile please try this: Thank you! ❤️ 💚 💙 💛 💜 |
|
@josevalim thanks, |
No description provided.