run the code formatter on calendar/date #6888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Oct 11, 2017
| %{calendar: calendar, year: year2, month: month2, day: day2}) do | ||
| @spec compare(Calendar.date(), Calendar.date()) :: :lt | :eq | :gt | ||
| def compare(%{calendar: calendar, year: year1, month: month1, day: day1}, %{ | ||
| calendar: calendar, |
There was a problem hiding this comment.
We can probably write this one as:
def compare(%{calendar: calendar} = date1, %{calendar: calendar} = date2) do
%{year: year1, month: month1, day: day1} = date1
%{year: year2, month: month2, day: day2} = date2
Could you please give it a tru?
josevalim
reviewed
Oct 11, 2017
| {:error, reason} -> | ||
| raise ArgumentError, "cannot convert #{inspect date} to target calendar #{inspect calendar}, reason: #{inspect reason}" | ||
| raise ArgumentError, | ||
| "cannot convert #{inspect(date)} to target calendar #{inspect(calendar)}, reason: #{ |
There was a problem hiding this comment.
Please use <> "reason #{inspect(reason)} " at the end and format again.
josevalim
reviewed
Oct 11, 2017
| def diff(%{calendar: Calendar.ISO, year: year1, month: month1, day: day1}, | ||
| %{calendar: Calendar.ISO, year: year2, month: month2, day: day2}) do | ||
| @spec diff(Calendar.date(), Calendar.date()) :: integer | ||
| def diff(%{calendar: Calendar.ISO, year: year1, month: month1, day: day1}, %{ |
There was a problem hiding this comment.
Please change similar to compare/2.
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.