-
Notifications
You must be signed in to change notification settings - Fork 340
Annotate modules visually when @moduledoc since: "..."
is present
#1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would like implementing this, but I'm not sure how this should look like :/
|
I will go ahead and say no on this one because, we would still need to propagate it, as someone can still be linked directly to the function, so I am not that sure the additional information and clutter is worth it, given we propagate and refer to it on all entries too. :) |
@josevalim mmm I disagree here, because:
I think this is a pretty big DX deal. Considering this feature is visually a really tiny addition, are we sure we want to let it go? 😬 |
What about something like "This module is available since v..." as the first sentence of the module doc, styled slightly different? |
Our goal is to move the search bar into the main page and, when we do so, we might move the cog icon, making it more or less cluttered, but I think right now is not the time for this. We can reevaluate in the future. |
@josevalim maybe we can out a solution for this and then re-evaluate when we do the changes you just mentioned? Like, we go with the sentence at the start of the moduledoc to get the feature and info to users, and then re-evaluate. 🙃 |
We typically don't automatically add sentences. If that's a concern, then Elixir can add it directly to its docs. I would personally wait, there is no reason to rush and churn. |
We recently made
@moduledoc since
propagate to all the types, functions, and macros in the module (#1680), but I think it would be really nice to have the module itself annotated with this.I was looking at
PartitionSupervisor
in Elixir, for example, and had to scroll through functions to know that all the functions were added in Elixir 1.14, which made me realize the whole module was added in Elixir 1.14. We can always annotate the module manually in the module-level doc (as I did in elixir-lang/elixir#12895), but I think visually showing the "since ...", like we do for functions and friends, could be nice for modules too.There was discussion around this in #1680 itself and we opted for a simple solution (propagating), but I wanted to figure out if there is appetite for the full-fledged feature, if someone is willing to take on the visual work (I’m not good at that 😉), and so on 🙃
Worst case, we can close this out and it'll help folks read about this feature in this issue at least 😄
The text was updated successfully, but these errors were encountered: