-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate :since metadata from modules #1680
Conversation
:since was showing for functions, types, and callbacks, but not for modules.
Can you please provide screenshots of how it looks like? IIRC we didn't have a placement for it. |
Will do in a few hours when at a computer, but yes it turns our we do 😬, and it looks good too 😁 I tested locally. |
@josevalim see screenshot 👇 |
I think the font is not matching the font we have in usual signatures, no? |
@josevalim I don't know 😄 Should it be monospaced? |
I think so, yes! |
@josevalim new commit should do it: |
Can you also please adjust the baseline? The fonts must all start at the same place from the bottom. Btw, this is what I meant we had no place for it. There is no design for them, so we need to take into account all of the design considerations that happen elsewhere on the page. |
@josevalim got it now. If I align the baseline with the module name, it looks pretty bad because it's then not aligned with the |
You can also love the icons baseline as well. The since and icons should have the same baseline anyway as the title anyway. :) |
@josevalim done, and the implementation is really simple as well. Ready for another review. |
💚 💙 💜 💛 ❤️ |
:since
was showing for functions, types, and callbacks, but not for modules.