Make launcher easier wrappable for different install locations #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'd probably need a similar change in |
|
Indeed! I hope I will be able to take core for that and docs later today. |
|
I added some small documentation now, and also added the environment |
|
Not sure why tests are failing… |
lukaszsamson
approved these changes
Feb 3, 2021
Yeah, the tests are flaky at the moment. It's something I'm trying to work on off-and-on #478 is an attempt in that direction although it may not fix this particular error. |
|
So then I remove the WIP tag and consider this "ready to merge". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the elixir-ls scripts check the
$ELS_INSTALL_PREFIXvariable to know where the LSP got installed.
This change makes it easier for external packagers to install ExLS to
locations appropriate to their packaging system, as then all they need
to do is to provide a small wrapper script that adjusts the
aforementioned variable in the environment.
The launcher will fall back to its default behaviour if the variable
is unset/empty in the environment.