Format the codebase

[whatyouhide]

It's a big diff but not a lot to check out :)

One thing to check is .travis.yml, which I updated to check for formatted files on CI.

[fertapric]

Are some of the changes on this file examples of "Example 2: multi-line function definitions"? Link: elixir-lang/elixir#6643

def translate(min_level, :error, :format, message) do
  {~c"Ranch listener" ++ _, [ref, protocol, pid, reason]} = message
  # ...
end

[josevalim]

We need to match on the top, unfortunately.

[fertapric]

What about?

def translate(min_level, :error, :format, data) do
  case data do
    # cowboy 1 format
    {~c"Ranch listener" ++ _, [ref, protocol, pid, reason]} ->
      translate_ranch(min_level, ref, protocol, pid, reason)

    # cowboy 2 format
    {~c"Ranch listener" ++ _, [ref, pid, _stream_id, _stream_pid, reason, _]} ->
      translate_ranch(min_level, ref, :cowboy_protocol, pid, reason)
      
    _ ->
      :none
  end
end

def translate(_min_level, _level, _kind, _data), do: :none

[fertapric]

Same here:

def send_file(conn, status, file, offset, length) when is_binary(file) do
  %Conn{adapter: {adapter, payload}, owner: owner} = conn
  # ...
end

[josevalim]

👍

[josevalim]

I would just match on the %Conn{} in the head because of better error messages in Elixir v1.5.

[fertapric]

Yeah, I completely forgot that when copy/pasting the param 😅 I've also updated the rest of the comments to match on %Conn{} = conn

[fertapric]

Maybe?

def delete_resp_header(%Conn{} = conn, key) when is_binary(key) do
  %{conn | resp_headers: List.keydelete(conn.resp_headers, key, 0)}
end

[fertapric]

Maybe?

def put_req_header(%Conn{} = conn, key, value) when is_binary(key) and is_binary(value) do
  validate_header_key_if_test!(conn.adapter, key)
  %{conn | req_headers: List.keystore(conn.req_headers, key, 0, {key, value})}
end

[whatyouhide]

Doesn't change much, I prefer the way it is right now.

[fertapric]

Maybe?

def fetch_query_params(%Conn{} = conn, opts) do
  %Conn{query_params: %Unfetched{}, params: params, query_string: query_string} = conn
  # ...
end

[fertapric]

Maybe?

def fetch_cookies(%Conn{} = conn, _opts) do
  %Conn{req_cookies: %Unfetched{}, resp_cookies: resp_cookies, req_headers: req_headers} = conn
  # ...
end

[fertapric]

Maybe?

time = padded_hour <> ":" <> padded_minute <> ":" <> padded_second <> " GMT"
date = padded_day <> " " <> month_name <> " " <> binary_year
weekday_name <> ", " <> date <> time

[josevalim]

We should use iodata to binary.

[fertapric]

Not 100% sure about this one, but the split in the new line looks a bit weird. Here is a suggestion:

with [plain_text, signature] = split,
     true <- byte_size(plain_text) > 0,
     true <- byte_size(signature) > 0,
     {:ok, payload} <- decode_legacy_base64(plain_text),
     {:ok, signature} <- decode_legacy_base64(signature) do
  {"HS1", payload, plain_text, signature}
else
  _ -> :error
end

[josevalim]

I think we can do plain_text != "" :)

[josevalim]

It feels the formatter could do a better job here. I will investigate.

[whatyouhide]

Yes, good catch, I noticed this but forgot to point it out. 💟

[josevalim]

I will merge and tackle Plug.Conn and the other comments dropped by @fertapric!

[josevalim]

❤️ 💚 💙 💛 💜