The module_str parameter of open_resource_type has to be NULL #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in
https://www.erlang.org/doc/apps/erts/erl_nif#enif_open_resource_type
This only leads to problems in debug builds as the value is
currently guarded by an assertion.
|
Odd. Makes sense as I never build the library in debug mode. Always in |
|
This has nothing to do with the library, it's about the BEAM. A debug BEAM will be compiled with the respective assertion and fail to load this NIF, see https://erlangforums.com/t/debug-emulator-fails-to-run-with-exqlite-nif/4399. |
|
Makes sense. I haven't built a debug BEAM or used one before. @filmor just curious, why were you running a debug build? Just wondering if I should be integrating it into my workflow for NIF development. |
|
I wasn't, @alanj853 was :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in https://www.erlang.org/doc/apps/erts/erl_nif#enif_open_resource_type.
This only leads to problems in debug builds as the value is currently guarded by an assertion.