fix: allow atom layout module names #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you write a test for this? I think you might be able to just add a layout default (as an atom) to one of the extensions in that test and then remove the explicit layout from one of the test markdown files being written to disk in that test. |
halostatue
force-pushed
the
allow-atom-layouts
branch
from
f3d34dd to
513af71
Compare
|
beautiful, just rebase on main and i'll get this merged. thanks a lot! |
String values for layout module names are required to be supported in the front matter, but it feels odd to require that they be strings in config. This enables the specification of layout modules as atoms and fixes a bug in PageExtension which required a layout value in the front matter at all times.
halostatue
force-pushed
the
allow-atom-layouts
branch
from
513af71 to
a577751
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String values for layout module names are required to be supported in
the front matter, but it feels odd to require that they be strings in
config. This enables the specification of layout modules as atoms and
fixes a bug in PageExtension which required a layout value in the
front matter at all times.