Skip to content

Support semantic tokens protocol #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 29, 2020
Merged

Support semantic tokens protocol #1721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3a2cd7d
[WIP] Add rudimentary semanticTokens support
sebastiansturm Apr 19, 2020
ff8e42b
Use buffer-local advice
sebastiansturm Apr 19, 2020
48f8e30
Don't request semantic tokens if unsupported
sebastiansturm Apr 20, 2020
6e9ba82
Use lsp-feature? to detect semanticTokens support
sebastiansturm Apr 20, 2020
9c03646
Prevent out-of-bounds access
sebastiansturm Apr 28, 2020
1e7dc2f
Update semantic highlighting docstrings
sebastiansturm May 24, 2020
bae93fa
[untested] Add support for token modifiers
sebastiansturm May 24, 2020
eaf1e35
Add some token types defined by clangd
sebastiansturm May 24, 2020
91b0a5e
Mention semantic tokens support in readme
sebastiansturm May 24, 2020
c392d05
Remove leftover `append'
sebastiansturm May 24, 2020
91e2cf6
Remove unused variables
sebastiansturm May 24, 2020
01f9b5b
Fix several issues raised by @yyoncho
sebastiansturm May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ most popular Emacs packages like `company`, `flycheck` and `projectile`.
- Ivy integration - [lsp-ivy](https://github.com/emacs-lsp/lsp-ivy/)
- Treemacs integration -
[lsp-treemacs](https://github.com/emacs-lsp/lsp-treemacs)
- Semantic highlighting (as currently implemented by JDT LS and
unreleased builds of clangd, cf. [Semantic highlighting
spec](https://github.com/microsoft/vscode-languageserver-node/pull/367))
- Semantic highlighting (using either the theia semantic highlighting protocol as implemented by JDT LS and some versions of clangd, or the semantic tokens protocol defined by LSP 3.16)
- [which-key](https://github.com/justbur/emacs-which-key/) integration
for better discovery

Expand Down
Loading