lsp-try-completion: make it pass-through so the basic style works #2405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyoncho
approved these changes
Dec 14, 2020
| @@ -470,12 +470,15 @@ The MARKERS and PREFIX value will be attached to each candidate." | |||
| ;; boundaries | |||
| ((equal (car-safe action) 'boundaries) nil) | |||
| ;; try-completion | |||
| ((null action) (cl-first (member probe (funcall candidates)))) | |||
| ((null action) | |||
| (when-let ((cands (funcall candidates))) | |||
There was a problem hiding this comment.
nit: can you use (not (cl-rest collection)) instead of comparing lenght to 1. I know that we have that on a few places but it is no the correct elisp.
There was a problem hiding this comment.
@yyoncho as a side note, cl-rest or cdr?
There was a problem hiding this comment.
Since cl-rest is alias of cdr and more expressive at the same time, IMO cl-rest is a clear winner here.
There was a problem hiding this comment.
Well, both convey the same meaning. To me, cdr is more intuitive, IMHO.
There was a problem hiding this comment.
I am in favour of cl-rest (or even rest if it was not deprecated). car/cdr/etc are archaisms kept only for historical reasons and IMHO they should be deprecated even in core code.
kiennq
force-pushed
the
bug/try-completion-pt
branch
from
80a9e1d to
9c0eef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
try-completionof completion function become pass through so basic completion style oflsp-capfworks.Also if there's only one completion result, return that value as common prefix.
Fix #2404
Also make the completion function of
lsp-modeto returnnilif the action flag doesn't match to predefined one.