feat(lsp-nix): Allow passing arguments to server #4728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julia DeMille <[email protected]>
github-actions
bot
added
documentation
client
jcs090218
approved these changes
Mar 6, 2025
jcs090218
reviewed
Mar 6, 2025
| @@ -54,6 +54,12 @@ | |||
| :type 'string | |||
| :package-version '(lsp-mode . "8.0.0")) | |||
|
|
|||
| (defcustom lsp-nix-nixd-server-arguments '() | |||
There was a problem hiding this comment.
I think setting it to nil is recommended for a later version of Emacs. 🤔
There was a problem hiding this comment.
I think setting it to
nilis recommended for a later version of Emacs. 🤔
Huh. Where could I find info on that?
There was a problem hiding this comment.
It used to be a compile warning (either Emacs 30 or 31), but it's gone now. 🤔 I guess the Emacs Devel included this but reverted it after a few weeks.
|
Thank you! |
jcs090218
pushed a commit
that referenced
this pull request
Mar 15, 2025
using push modifies lsp-nix-nixd-server-arguments fix #4728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful sometimes. See the features page.
I added a new entry to CHANGELOG.md
I updated documentation if applicable (Not applicable.docsfolder)