syntax entry for dollar sign

[mallt]

While using avy-goto-word-1 (https://github.com/abo-abo/avy) I noticed I couldn't jump to the first letter of php variables. After setting the dollar sign as symbol constituent with

(modify-syntax-entry ?$ "_" php-mode-syntax-table)

avy-goto-word-1 starting working as expected.

Would this be a correct addition to the php-mode-syntax-table?

[syohex]

[Note] shell-script-mode sets $ as expression prefix class, while perl-mode sets $ as escape class.

I'll check other programming languages modes.

[syohex]

ruby-mode sets $ as prefix class.

[mallt]

Thank you @syohex! I checked your modification with avy-goto-word-1 and it works as expected now.

[syohex]

I have merged

[mallt]

@syohex I noticed this change causes (thing-at-point 'symbol) to drop the dollar sign from variables. Reading https://www.gnu.org/software/emacs/manual/html_node/elisp/Syntax-Class-Table.html, wouldn't it be better to classify the dollar sign as a symbol constituent?

Thanks!

[zonuexe]

@mallt
I do not agree with confusing users by changing syntax-table.
As an alternative, I implemented (thing-at-point 'php-token).
(zonuexe/php-util.el@218ad43 is in my private package, but if this function is seems to stabilize, I propose to integrate it into php-mode.)

Is this what you expected?

[mallt]

I was just thinking that if (thing-at-point 'symbol) doesn't return the expected result the syntax table might not be correct. To me it seems the dollar in php is rather a symbol constituent than an expression prefix, but I guess there are no strict rules to follow here.