Updated to be in line with how ember-cli-deploy handles context data #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the object passed in by the pipeline task is accessed under `context.deployment`. Also, now returning the values we want put onto the context object. Previously we were adding them to the object manually, but now ember-cli-deploy adds whatever is returned by the plugin to the context
achambers
force-pushed
the
update-to-handle-context-data
branch
from
7b87cea to
d572323
Compare
achambers
changed the title
achambers
changed the title
achambers
pushed a commit
that referenced
this pull request
Apr 22, 2015
Updated to be in line with how ember-cli-deploy handles context data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the object passed in by the pipeline task is accessed under
context.deployment.Also, now returning the values we want put onto the context object.
Previously we were adding them to the object manually, but now
ember-cli-deploy adds whatever is returned by the plugin to the context