add support for caching revision data #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2016
Merged
| @@ -80,7 +80,7 @@ module.exports = { | |||
|
|
|||
| this.log('Uploading `' + filePath + '`', { verbose: true }); | |||
| return this._readFileContents(filePath) | |||
| .then(redisDeployClient.upload.bind(redisDeployClient, keyPrefix, revisionKey)) | |||
| .then(redisDeployClient.upload.bind(redisDeployClient, keyPrefix, revisionKey, context.revisionData)) | |||
There was a problem hiding this comment.
should this be read from config? i.e. this.readConfig('revisionData')
ghedamat
force-pushed
the
enrich-revision-data
branch
3 times, most recently
from
9c591b6 to
f9e695d
Compare
ghedamat
force-pushed
the
enrich-revision-data
branch
from
f9e695d to
43fe41a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step in tackling ember-cli-deploy/ember-cli-deploy#305
see
ember-cli-deploy/ember-cli-deploy-revision-data#29
ember-cli-deploy/ember-cli-deploy-display-revisions#8