Skip to content

Add a failing test for #27 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

reidab
Copy link
Contributor

@reidab reidab commented Feb 23, 2016

"README says git-tag-commit uses most recent tag, but it doesn't work unless current commit has a tag"

I was going to work further on a solution, but it looks like the upstream git-repo-info module doesn't actually support fetching the most recent git tag.

@ghedamat
Copy link
Contributor

thanks @reidab for this

will try to get to it when we can

if you're still interested in fixing it might be worth checking
#29

I'm using simple-git there and it will likely be added to the project once that PR is merged

maybe that will help you fixing this issue

@lukemelia
Copy link
Contributor

@reidab @ghedamat can this be closed?

"README says git-tag-commit uses most recent tag, but it doesn't work
unless current commit has a tag"
@lukemelia
Copy link
Contributor

Closing for lack of activity.

@lukemelia lukemelia closed this May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants